Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Add test coverage for BZ:2238952 and BZ:2025523 #15455

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[6.15.z] Add test coverage for BZ:2238952 and BZ:2025523 #15455

merged 1 commit into from
Jul 9, 2024
+140 −6

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15205

Problem Statement

Missing coverage for BZ:2238952 and BZ:2268544, where we verified Customize host button works to provision a discovered host with a few customizations.

Solution

Add test coverage for BZ:2238952 and BZ:2268544, to verify functionality of discovery provisioning with Customize host button with a few customizations, and also covering BZ:2025523 where we've validated the assigned Ansible roles to a HostGroup gets auto executed when host is provisioned.
Also, verifying new test and modifying existing test to validate if provisioning is sucessfull on new host UI instead of old UI

Related Issues

SatelliteQE/airgun#1397

@Gauravtalreja1 @web-flow
Add test coverage for BZ:2238952 and BZ:2025523 (#15205)
bb14de6 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit c3d4f63)
@Satellite-QE Satellite-QE requested a review from a team as a code owner June 19, 2024 10:42
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jun 19, 2024
@Satellite-QE
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host
provisioning: true
deploy_rhel_version: '9'
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jun 19, 2024
@Gauravtalreja1
Copy link
Collaborator 

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7446
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 7 deselected, 173 warnings in 4531.92s (1:15:31) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 19, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7453
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 7 deselected, 228 warnings in 5617.91s (1:33:37) ==========

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7456
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 7 deselected, 266 warnings in 6459.28s (1:47:39) ==========

@Gauravtalreja1
Copy link
Collaborator

PRT is expected to fail here due to hussh issue with discovery tests, we can merge this PR and handle the failure in separately with other discovery tests

shubhamsg199
shubhamsg199 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@shubhamsg199 shubhamsg199 merged commit d7b12b2 into 6.15.z Jul 9, 2024
15 of 18 checks passed
@shubhamsg199 shubhamsg199 deleted the cherry-pick-6.15.z-c3d4f634a9a2fc09dfe734494900f042d62de4a6 branch July 9, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @Gauravtalreja1 @shubhamsg199